Split Refactor Part 1 #2086
Split Refactor Part 1 #2086
Conversation
xudongzheng
force-pushed
the
split-refactor1-pr
branch
4 times, most recently
from
ded3c1c
to
96c028f
Compare
xudongzheng
force-pushed
the
split-refactor1-pr
branch
2 times, most recently
from
a52ce6a
to
30ff612
Compare
|
@xudongzheng any update on this? I was looking to build a wired-split board and I'd love to try this out if it's stable enough to play with. |
This PR is the refactoring portion and will likely be reviewed separately from the actual split serial PR #2080. That PR has a new commit f28e8fc with code for sending key press data from peripheral to central. Functionally that's was the main missing part for testing on an actual keyboard. It should work in theory though I've only tested with my development board. That PR as a whole should still be considered experimental and is still missing some stuff. |
|
Cool, thanks for the update. I'll check that out. |
xudongzheng
force-pushed
the
split-refactor1-pr
branch
from
30ff612
to
fcc7837
Compare
xudongzheng
force-pushed
the
split-refactor1-pr
branch
from
fcc7837
to
63c82cd
Compare
xudongzheng
force-pushed
the
split-refactor1-pr
branch
from
63c82cd
to
29191e7
Compare
|
Hi @xudongzheng. Thanks for your work on this topic! Is there any progress to be expected on the "wired split" front? Would a sponsorship help? |
@sontags The complete PR in #2080 is largely functional. To my knowledge, there are quite a few people running it successfully, and you can find several relevant discussions on Discord. The refactoring part of that PR is split into this PR for ease of review. The main PR will be cleaned up and taken out of "draft" status after this PR is resolved. |
Nick-Munnich
added
core
xudongzheng
force-pushed
the
split-refactor1-pr
branch
from
29191e7
to
5f0c8af
Compare
|
Seems this got out of sync with the main branch again. @xudongzheng, did you get any feedback from the maintainers outside from this PR? Would be great to see this, and the subsequent PRs landing. |
No, the wired split PRs have not been reviewed yet. I believe it's on Pete's agenda though he's currently focused on other areas of ZMK. |
The motivation for this PR is to be the first part of #2080. The commits should be pretty self-contained and easy to review.
The split run and indicator I haven't refactored yet since that will require some larger changes related to how multiple peripherals are handled. That will likely be part of a separate PR later.